fix: use useFetch for useDependencyAnalysis#551
Merged
danielroe merged 4 commits intonpmx-dev:mainfrom Jan 31, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
Author
|
@danielroe I think ci/knip is lying. Can I help you with: webpro-nl/knip#1265 ? (I removed some unnecessary imports) |
danielroe
approved these changes
Jan 31, 2026
Member
|
please! do you want permissions for my fork? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the state key was not updated when the version or package changed.
Now, requests are deduped correctly as well. We could remove
useDependencyAnalysis()entirely in favour of just havinguseFetch(() =>`/api/registry/vulnerabilities/${encodePackageName(toValue(packageName))}/v/${toValue(version)}`)There will be two followup issues:
api/registry/vulnerabilities/does not handle scoped packages #552)