feat(i18n): complete some zh-CN translation#1868
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis pull request updates the Simplified Chinese locale (i18n/locales/zh-CN.json). It adds a new top-level Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
i18n/locales/zh-CN.json (1)
96-97: Minor inconsistency: ellipsis character usage.Lines 96-97 (and 101) use
...(three ASCII periods), whilst the rest of the file consistently uses…(Unicode ellipsis U+2026). For example, line 44 uses"搜索中…"and line 157 uses"加载中…".Consider updating for consistency:
"正在加载评论..."→"正在加载评论…""更新中..."→"更新中…""还有 {count} 条回复..."→"还有 {count} 条回复…"🔧 Suggested fix
- "loading_comments": "正在加载评论...", - "updating": "更新中...", + "loading_comments": "正在加载评论…", + "updating": "更新中…", "reply_count": "{count} 条回复 | {count} 条回复", "like_count": "{count} 个赞 | {count} 个赞", "repost_count": "{count} 次转发 | {count} 次转发", - "more_replies": "还有 {count} 条回复... | 还有 {count} 条回复..." + "more_replies": "还有 {count} 条回复… | 还有 {count} 条回复…"lunaria/files/zh-CN.json (1)
95-96: Minor inconsistency: ellipsis character usage.Same issue as in
i18n/locales/zh-CN.json— these lines use...(three ASCII periods) whilst the rest of the file uses…(Unicode ellipsis).🔧 Suggested fix
- "loading_comments": "正在加载评论...", - "updating": "更新中...", + "loading_comments": "正在加载评论…", + "updating": "更新中…", "reply_count": "{count} 条回复 | {count} 条回复", "like_count": "{count} 个赞 | {count} 个赞", "repost_count": "{count} 次转发 | {count} 次转发", - "more_replies": "还有 {count} 条回复... | 还有 {count} 条回复..." + "more_replies": "还有 {count} 条回复… | 还有 {count} 条回复…"
There was a problem hiding this comment.
Pull request overview
Adds the remaining missing zh-CN translations so the UI can render newly introduced sections (blog, downloads subtitle, compare diff messaging, vacations page) without falling back to English.
Changes:
- Add zh-CN translations for the new Blog section (including Bluesky comments/likes UI strings).
- Add missing zh-CN strings for weekly downloads subtitle and compare diff warnings/titles.
- Add zh-CN translations for the vacations/recharging page (i18n/locales only).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lunaria/files/zh-CN.json | Updates Lunaria-tracked zh-CN dictionary entries for footer/blog and some compare/download strings. |
| i18n/locales/zh-CN.json | Updates app runtime zh-CN translations, including blog strings, compare/download strings, and adds the vacations page translations. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
i18n/locales/zh-CN.json (1)
1166-1170: Consider omitting emptypdsplaceholders until translated keys exist.Empty objects add noise without user-facing value; omitting them may keep locale payload cleaner.
Based on learnings: In the npmx.dev project, new or changed entries in i18n translation files may be omitted from non-English languages.
zh-CN translation
📚 Description
Complete some
zh-CNtranslation