Skip to content

feat(i18n): complete some zh-CN translation#1868

Merged
whitep4nth3r merged 5 commits intonpmx-dev:mainfrom
zyyv:i18n-cn
Mar 3, 2026
Merged

feat(i18n): complete some zh-CN translation#1868
whitep4nth3r merged 5 commits intonpmx-dev:mainfrom
zyyv:i18n-cn

Conversation

@zyyv
Copy link
Contributor

@zyyv zyyv commented Mar 3, 2026

📚 Description

Complete some zh-CN translation

Copilot AI review requested due to automatic review settings March 3, 2026 08:35
@vercel
Copy link

vercel bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 3, 2026 8:54am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 3, 2026 8:54am
npmx-lunaria Ignored Ignored Mar 3, 2026 8:54am

Request Review

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/zh-CN.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b055b94 and 72ae5af.

📒 Files selected for processing (1)
  • i18n/locales/zh-CN.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • i18n/locales/zh-CN.json

📝 Walkthrough

Walkthrough

This pull request updates the Simplified Chinese locale (i18n/locales/zh-CN.json). It adds a new top-level blog object with title, heading, meta_description, author.view_profile and multiple atproto comment/interaction keys. It adds footer.blog, downloads.subtitle, and three file_changes keys: file_too_large, file_size_warning, and compare_versions_title. Total net change: +29/-1 lines.

Possibly related PRs

Suggested reviewers

  • danielroe
  • 9romise
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly relates to the changeset, which adds Chinese (zh-CN) translations for blog, footer, downloads, and file changes UI components.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
i18n/locales/zh-CN.json (1)

96-97: Minor inconsistency: ellipsis character usage.

Lines 96-97 (and 101) use ... (three ASCII periods), whilst the rest of the file consistently uses (Unicode ellipsis U+2026). For example, line 44 uses "搜索中…" and line 157 uses "加载中…".

Consider updating for consistency:

  • "正在加载评论...""正在加载评论…"
  • "更新中...""更新中…"
  • "还有 {count} 条回复...""还有 {count} 条回复…"
🔧 Suggested fix
-      "loading_comments": "正在加载评论...",
-      "updating": "更新中...",
+      "loading_comments": "正在加载评论…",
+      "updating": "更新中…",
       "reply_count": "{count} 条回复 | {count} 条回复",
       "like_count": "{count} 个赞 | {count} 个赞",
       "repost_count": "{count} 次转发 | {count} 次转发",
-      "more_replies": "还有 {count} 条回复... | 还有 {count} 条回复..."
+      "more_replies": "还有 {count} 条回复… | 还有 {count} 条回复…"
lunaria/files/zh-CN.json (1)

95-96: Minor inconsistency: ellipsis character usage.

Same issue as in i18n/locales/zh-CN.json — these lines use ... (three ASCII periods) whilst the rest of the file uses (Unicode ellipsis).

🔧 Suggested fix
-      "loading_comments": "正在加载评论...",
-      "updating": "更新中...",
+      "loading_comments": "正在加载评论…",
+      "updating": "更新中…",
       "reply_count": "{count} 条回复 | {count} 条回复",
       "like_count": "{count} 个赞 | {count} 个赞",
       "repost_count": "{count} 次转发 | {count} 次转发",
-      "more_replies": "还有 {count} 条回复... | 还有 {count} 条回复..."
+      "more_replies": "还有 {count} 条回复… | 还有 {count} 条回复…"

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 524919e and f169976.

📒 Files selected for processing (2)
  • i18n/locales/zh-CN.json
  • lunaria/files/zh-CN.json

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the remaining missing zh-CN translations so the UI can render newly introduced sections (blog, downloads subtitle, compare diff messaging, vacations page) without falling back to English.

Changes:

  • Add zh-CN translations for the new Blog section (including Bluesky comments/likes UI strings).
  • Add missing zh-CN strings for weekly downloads subtitle and compare diff warnings/titles.
  • Add zh-CN translations for the vacations/recharging page (i18n/locales only).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
lunaria/files/zh-CN.json Updates Lunaria-tracked zh-CN dictionary entries for footer/blog and some compare/download strings.
i18n/locales/zh-CN.json Updates app runtime zh-CN translations, including blog strings, compare/download strings, and adds the vacations page translations.

zyyv and others added 3 commits March 3, 2026 16:39
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
i18n/locales/zh-CN.json (1)

1166-1170: Consider omitting empty pds placeholders until translated keys exist.

Empty objects add noise without user-facing value; omitting them may keep locale payload cleaner.

Based on learnings: In the npmx.dev project, new or changed entries in i18n translation files may be omitted from non-English languages.


ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f169976 and b055b94.

📒 Files selected for processing (1)
  • i18n/locales/zh-CN.json

@zyyv zyyv changed the title feat(i18n): complete the remaining translation feat(i18n): complete some zh-CN translation Mar 3, 2026
@whitep4nth3r whitep4nth3r added this pull request to the merge queue Mar 3, 2026
Merged via the queue into npmx-dev:main with commit 1eb99f3 Mar 3, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants