Skip to content

fix: correct hydration for instant search #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 1 commit into from
Mar 3, 2026
Merged

fix: correct hydration for instant search #1866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions app/components/InstantSearch.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<script setup lang="ts">
import { useSettings } from '~/composables/useSettings'

const { settings } = useSettings()

onPrehydrate(el => {
const settingsSaved = JSON.parse(localStorage.getItem('npmx-settings') || '{}')
const enabled = settingsSaved.instantSearch
if (enabled === false) {
el.classList.add('hidden')
}
})
</script>

<template>
<p
id="instant-search-advisory"
class="text-fg-muted text-sm text-pretty"
:class="settings.instantSearch ? '' : 'hidden'"
>
<span
class="i-lucide:zap align-middle text-fg relative top-[-0.1em] me-1"
style="font-size: 0.8em"
aria-hidden="true"
></span>
<i18n-t keypath="search.instant_search_advisory">
<template #label>
<strong>{{ $t('search.instant_search') }}</strong>
</template>
<template #settings>
<LinkBase to="/settings">{{ $t('settings.title') }}</LinkBase>
</template>
<template #shortcut>
<kbd class="text-xs"
><kbd class="text-fg bg-bg-muted border border-border px-1 py-[2px] rounded-sm">Ctrl</kbd
>+<kbd class="text-fg bg-bg-muted border border-border px-1 py-[2px] rounded-sm"
>/</kbd
></kbd
>
</template>
</i18n-t>
</p>
</template>
29 changes: 1 addition & 28 deletions app/pages/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,34 +107,7 @@ defineOgImageComponent('Default', {
</div>
</div>

<p
v-if="settings.instantSearch"
id="instant-search-advisory"
class="text-fg-muted text-sm text-pretty"
>
<span
class="i-lucide:zap align-middle text-fg relative top-[-0.1em] me-1"
style="font-size: 0.8em"
aria-hidden="true"
></span>
<i18n-t keypath="search.instant_search_advisory">
<template #label>
<strong>{{ $t('search.instant_search') }}</strong>
</template>
<template #settings>
<LinkBase to="/settings">{{ $t('settings.title') }}</LinkBase>
</template>
<template #shortcut>
<kbd class="text-xs"
><kbd class="text-fg bg-bg-muted border border-border px-1 py-[2px] rounded-sm"
>Ctrl</kbd
>+<kbd class="text-fg bg-bg-muted border border-border px-1 py-[2px] rounded-sm"
>/</kbd
></kbd
>
</template>
</i18n-t>
</p>
<InstantSearch />
</form>
</search>

Expand Down
Loading