Skip to content

fix: add date in chart tooltip #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphieros merged 4 commits into from
Mar 2, 2026
Merged

fix: add date in chart tooltip #1831

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7e55cd
fix: add date in chart tooltip
RYGRIT Mar 2, 2026
6f17a8b
fix: 0 timestamp
RYGRIT Mar 2, 2026
98aa4c5
fix: remove isModal check
graphieros Mar 2, 2026
b10c2af
Merge branch 'main' into fix/add-date-in-chart-tooltip
graphieros Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion app/components/Package/TrendsChart.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,6 +1100,17 @@ const datetimeFormatterOptions = computed(() => {
}[selectedGranularity.value]
})

// Cached date formatter for tooltip
const tooltipDateFormatter = computed(() => {
const granularity = displayedGranularity.value
return new Intl.DateTimeFormat(locale.value, {
year: 'numeric',
month: granularity === 'yearly' ? undefined : 'short',
day: granularity === 'daily' || granularity === 'weekly' ? 'numeric' : undefined,
timeZone: 'UTC',
})
})

const sanitise = (value: string) =>
value
.replace(/^@/, '')
Expand Down Expand Up @@ -1598,11 +1609,23 @@ const chartConfig = computed<VueUiXyConfig>(() => {
borderColor: 'transparent',
backdropFilter: false,
backgroundColor: 'transparent',
customFormat: ({ datapoint: items }) => {
customFormat: ({ datapoint: items, absoluteIndex }) => {
if (!items || pending.value) return ''

const hasMultipleItems = items.length > 1

// Format date for multiple series datasets
let formattedDate = ''
if (hasMultipleItems && absoluteIndex !== undefined) {
const index = Number(absoluteIndex)
if (Number.isInteger(index) && index >= 0 && index < chartData.value.dates.length) {
const timestamp = chartData.value.dates[index]
if (typeof timestamp === 'number') {
formattedDate = tooltipDateFormatter.value.format(new Date(timestamp))
}
}
}

const rows = items
.map((d: Record<string, any>) => {
const label = String(d?.name ?? '').trim()
Expand Down Expand Up @@ -1635,6 +1658,7 @@ const chartConfig = computed<VueUiXyConfig>(() => {
.join('')

return `<div class="font-mono text-xs p-3 border border-border rounded-md bg-[var(--bg)]/10 backdrop-blur-md">
${formattedDate ? `<div class="text-2xs text-[var(--fg-subtle)] mb-2">${formattedDate}</div>` : ''}
<div class="${hasMultipleItems ? 'flex flex-col gap-2' : ''}">
${rows}
</div>
Expand Down
Loading