fix: disable some keyboard shortcuts when it's disabled in settings#1780
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
…some-shortkeys-work-when-disabled-in-settings
…ttps://github.com/alex-key/npmx.dev into fix/some-shortkeys-work-when-disabled-in-settings
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds keyboard shortcuts guards to keyboard event handlers across two components. The changes introduce a Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔗 Linked issue
Resolves #1779
🧭 Context
In #1537 we've added a mechanism which allows user to disable all custom keyboard shortcuts in Settings. So it does not conflict with browser, os or other tools user might use to browse
📚 Description
Some pages in the app still use custom keyboard shortcuts. This PR adds logic to disable custom behavior for the following areas: