Repository navigation
ggml : add QSA sparse Flash Attention on V100 - #21
Merged
Merged
Conversation
Add the V100-only sparse 16x4 D256 Flash Attention route for the QSA Q8_0 shape while retaining existing dense fallbacks and 1024-query behavior. Add deterministic sparse fixtures, positive cases, controls, and performance cells. Assisted-by: Codex
7 of 21 tasks
Owner
Author
CI triage and handoff (2026-10-03)The two completed Windows failures repeat the same signatures seen on PR17:
These are recurring signatures, not a confirmed root cause or proof of an infrastructure failure. The owner authorized marking this reviewed head ready and squash-merging it after the exact-head, issue, and base checks. Root retains the combined build, deployment, performance, and context acceptance; issue #9 remains open. |
novkien
marked this pull request as ready for review
October 3, 2026 12:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add an SM70-only sparse Flash Attention route for the Qwen QSA D256/GQA12/Q8_0 shape, using the 16x4 tile and the existing 2051-token mask bound. The route keeps full-Q=1024 and unsupported shapes on existing paths. Deterministic test fixtures cover disjoint and sliding-window masks.
Addresses #9
Validation
A bounded trace of an actual long-context proxy prefill recorded 20 sparse Flash launches across all four V100s, including Q=1020 with KV=70144 and Q=326 with KV=69120. This confirms route selection for the traced shapes; the trace package was excluded from performance measurements. Cold 8k/32k K/V lengths remain below the sparse threshold, and full Q=1024 is explicitly excluded. These operator results do not claim an end-to-end model speedup.
The PR is ready for review. Final combined deployment, near-full-context, and performance acceptance remain with the root owner; issue #9 stays open until that work is recorded.
Requirements