fix: add aarch64 support#304
Merged
Merged
Conversation
LoadState only needs Linux shared memory, 64-bit pointer width, and 64-bit atomics, all of which aarch64-unknown-linux-gnu satisfies. Relax the x86_64-only cfg guard accordingly.
hxieustc
force-pushed
the
fix/add-aarch64-support
branch
from
762f333 to
2993bd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pegaflow is hard coded for x86_64. If we run pegaflow on GB200 or similar architectures, we need to add support for arm64.
Fix
Currently pegaflow does not bind to specific architectures. The only hardware platform architecture specific bindings are (1) 64-bit pointers, (2) 64-bit atomics via AtomicI64. Both of which are supported by arm64. Thus pegaflow can run on arm64 / aarch64 platforms.
The fix is very simple and straightforward:
Instead of using
#[cfg(not(all(target_arch = "x86_64", target_os = "linux")))]We can use
+#[cfg(not(all(target_os = "linux", target_pointer_width = "64", target_has_atomic = "64")))]to allow any architecture that supports linux (shared memory) and 64-bit points and 64-bit atomic. arm64/aarch64 naturally follows in this category.