fix(ci): install libibverbs-dev in release wheel build#303
Merged
Conversation
The pegaflow-transfer v2 RDMA engine (#297) made build.rs require infiniband/verbs.h at build time. ci.yml installs libibverbs-dev but release.yml did not, so the v0.22.4 wheel build panicked at pegaflow-transfer/build.rs:24. Install the RDMA headers in release.yml to match ci.yml. pre-commit skipped: the always-run 'cargo test --release' hook panics on this host with cudarc 'libcudart.so: undefined symbol: cudaEventElapsedTime_v2' (env-only); this is a CI-yaml-only change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
pegaflow-transferv2 RDMA engine (#297) madepegaflow-transfer/build.rsrequireinfiniband/verbs.hat build time.ci.ymlwas updated toapt-get install ... libibverbs-dev, butrelease.ymlwas not — so the v0.22.4 release wheel build panicked:Failed run: https://github.com/novitalabs/pegaflow/actions/runs/26620616554
Fix
Add
libibverbs-devto therelease.ymlapt install step (mirrors the three install steps inci.yml).Follow-up
After merge, the
v0.22.4tag will be moved onto the fixed commit to re-fire the release (the prior run failed before the PyPI publish step, so nothing was published).