fix behavior when multiple tags are selected - #2
Open
shunlog wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when multiple tags are selected, toggling the scratch off removes only the first one from its tags, so it still remains on the screen if it happened to be present in the other tags as well.
This patch makes it work as expected - all the selected tags are removed from the scratchpad's tags. To make it more consistent, maybe we should make the
turn_onmethod to handle multiple tags as well?BTW, I'm new to lua. How the hell is there no
table.find_by_valueor something? This loop stinks, but I copied the code from AwesomeWM'sclient:toggle_tag(t)so I assume this is the standard approach.