Skip to content

fix: replace watcher when rewatching#906

Merged
JohnTitor merged 2 commits intonotify-rs:mainfrom
JohnTitor:consistent-rewatch-recur
Apr 29, 2026
Merged

fix: replace watcher when rewatching#906
JohnTitor merged 2 commits intonotify-rs:mainfrom
JohnTitor:consistent-rewatch-recur

Conversation

@JohnTitor
Copy link
Copy Markdown
Member

Description

Fix #708

Currently, rewatching behavior varies by backend and brings some confusion like #708.
This makes it consistent over all the backend and documents its behavior.

Related Issues

@dfaust
Copy link
Copy Markdown
Member

dfaust commented Apr 26, 2026

Looks good. Although I would prefer if you could add some comments to the inotify and kqueue code, as well as recursive_user_watch_ancestor. Those parts are non-trivial and I did not verify them in detail. But the tests look good.

@JohnTitor JohnTitor force-pushed the consistent-rewatch-recur branch from 8dd11ce to f227937 Compare April 28, 2026 12:06
@JohnTitor JohnTitor merged commit 60a6b27 into notify-rs:main Apr 29, 2026
32 of 34 checks passed
@JohnTitor
Copy link
Copy Markdown
Member Author

Makes sense, added in f227937

@JohnTitor JohnTitor deleted the consistent-rewatch-recur branch April 29, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify what happens if you multi-watch a directory.

2 participants