Verify integrity and authenticity of server-returned XML (XMLDSig) #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… option Add "-chkCert4InfoXML" & "-chkCertKeyId4XML=" options to verify the integrity & authenticity of XML responses (XMLDsig) returned by server, preventing them from being altered or hijacked.
donho
added a commit
to donho/notepad-plus-plus
that referenced
this pull request
Jan 26, 2026
…LDsig) This security enhancement depends on notepad-plus-plus/wingup#102.
xomx
reviewed
Jan 27, 2026
|
|
||
| bool SecurityGuard::verifyXmlSignature(const std::string& xmlData, const std::wstring& trustedThumbprint) | ||
| { | ||
| HRESULT hr = CoInitializeEx(NULL, COINIT_APARTMENTTHREADED); |
There was a problem hiding this comment.
- not checking for possible
CoInitializeExfailure - missing enclosing
CoUninitialize()
Didn't try the PR, currently I cannot participate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "-chkCert4InfoXML" & "-chkCertKeyId4XML=" options to verify the integrity & authenticity of XML responses (XMLDsig) returned by server, preventing them from being altered or hijacked.
The xml files are signed by xmlSigner:
https://github.com/donho/xmlSigner