Repository navigation
Conversation
parseMetaBlock (TS) と parse_meta_block (Rust、sidecar の loopback 同意) が 行コメントの除去を `###` ブロック全体の正規表現で行っていたため、 `default: "https://example.com"` のような文字列の中の `//` 以降も消えて JSON が壊れ、fallback で config が丸ごと落ちていた。 - 文字列リテラルの内外を見てコメントを落とす走査に置き換える (両側) - JSON.parse に失敗して fallback に落ちたときは console.warn に残す (TS) - 共有 golden に「文字列の中の // はコメントではない」のベクトルを足す Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
引用符の無いキーを `"key":` にする置換が行頭だけを見ていたため、
`url: { type: "string", label: "URL" }` のような 1 行形式では 2 つ目以降の
キーが引用符で包まれず JSON が壊れていた。
コメント除去とキーの引用符付けを、文字列リテラルの外でだけ判定する
1 つの走査 (normalizeMetaBody / normalize_meta_body) にまとめ、
`{` と `,` の後でもキーを拾うようにした。TS と Rust の両方、golden に
1 行形式のベクトルを追加。
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
fix(plugin): ### メタデータの文字列中の // をコメントとして落とさない (#1340)
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
API surface diff外部アプリ向け API 面 ( Full diffdiff --git a/src-tauri/openapi.json b/src-tauri/openapi.json
index 2864da6..51e5dcc 100644
--- a/src-tauri/openapi.json
+++ b/src-tauri/openapi.json
@@ -6,7 +6,7 @@
"license": {
"name": "MIT"
},
- "version": "1.103.0"
+ "version": "1.103.1"
},
"paths": {
"/api": {
|
github-actions
Bot
added
rust
Deploying notedeck with
|
| Latest commit: |
6b27946
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9eb0b8b3.notedeck-d3a.pages.dev |
| Branch Preview URL: | https://develop.notedeck-d3a.pages.dev |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更一覧
内容
プラグインの
###メタデータ解析の修正だけの patch リリース。文字列の中のhttps://を行コメントとして落としてconfigが丸ごと消えていた (misstore の mfm-search-engine が起動時に落ちる) のと、1 行形式のオブジェクトのキーが読めていなかったのを、TS と Rust (sidecar の loopback 同意) の両方で直した。Closes #1340
🤖 Generated with Claude Code