Repository navigation
fix(plugins): mfm-search-engine の ### メタデータから https:// を除く - #101
Merged
Merged
Conversation
…の解析で // 以降が消えて Plugin:config が空になる) #100 で etherscan-autolink / web-search は直したが、このプラグインの config.engine の description にも https:// が残っていた。NoteDeck 1.103 までは ### 内の // 以降をコメントとして落とすため config が丸ごと消え、起動時に Plugin:config.engine が null で resolveTemplate の trim() が落ちていた (notedeck#1340)。 - description から // を除き、例はスキーム無し (search.example.com/?q=) にする - スキームの無い設定値には https:// を足す (etherscan-autolink と同じ扱い) - 設定値が文字列でない / 空のときは警告に落とす - version 1.0.1 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜ
#100 で etherscan-autolink / web-search は直したが、mfm-search-engine の
config.engineのdescriptionにもhttps://が残っていた。NoteDeck 1.103 までは###内の//以降をコメントとして落とすためconfigが丸ごと消え、起動時にPlugin:config.engineが null でresolveTemplateのtrim()が落ちる (notedeck-dev/notedeck#1340 のログはこのプラグイン)。NoteDeck 側は notedeck-dev/notedeck#1341 で直るが、今の 1.103.0 でも動くようにする。何を
descriptionから//を除き、例はスキーム無し (search.example.com/?q=) にするhttps://を足す (etherscan-autolink と同じ扱い)。https://付きの値は従来どおり通るpnpm registry:build済み確認
###ブロック内の//がゼロ (1.103 までの素朴な除去でも壊れない)parsePluginMetaでconfig.engineが読める (vitest の使い捨てテストで確認)pnpm contract:verify合格 158 / 不合格 0🤖 Generated with Claude Code