Use alternative JinjaSQL branch/build compatible with jinja2>=3.0.#77
Merged
Conversation
…mpatible with jinja2>=3.0
added 2 commits
January 27, 2023 17:02
… poetry install packages directly from github.
…rying to poetry install packages directly from github." This reverts commit 90661b6.
tizz98
approved these changes
Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use this alternate fork of JinjaSQL that has been made compat with modern jinja2. Nice person on interweb has already done the work bringing JinjaSQL up to speed with using 3.X series Jinja2 (sic).
See their PR sripathikrishnan/jinjasql#53 trying to get this into main JinjaSQL.
When switching to this, we see happiness and upgraded jinja2 and markupsafe. Should then be compatible with that package the end user is trying to install that wants jinja2>3.0.
Package operations: 3 installs, 0 updates, 0 removals
• Installing markupsafe (2.1.2)
• Installing jinja2 (3.1.2)
• Installing jinjasql (0.1.9 f8c62d1)
The existing sql magic + jinja templating unit tests pass.