feat: export the PluginPrimitiveSigner to enable signing with PKCS#7#572
Open
dallasd1 wants to merge 2 commits intonotaryproject:mainfrom
Open
feat: export the PluginPrimitiveSigner to enable signing with PKCS#7#572dallasd1 wants to merge 2 commits intonotaryproject:mainfrom
dallasd1 wants to merge 2 commits intonotaryproject:mainfrom
Conversation
Signed-off-by: Dallas Delaney <dadelan@microsoft.com>
…cFromPlugin Signed-off-by: Dallas Delaney <dadelan@microsoft.com>
dallasd1
requested review from
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
dallasd1
commented
Mar 17, 2026
| } | ||
|
|
||
| // GetKeySpecFromPlugin retrieves the key specification from a plugin by calling DescribeKey. | ||
| func GetKeySpecFromPlugin(ctx context.Context, p plugin.SignPlugin, keyID string, pluginConfig map[string]string) (signature.KeySpec, error) { |
Author
There was a problem hiding this comment.
This is needed for the CLI PR that will pull the signing type to include in the PKCS#7 envelope
dallasd1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type PluginPrimitiveSigner is needed for generating PKCS#7 signatures by code living in the notation CLI repo. That new (CLI) logic bypasses the PluginSigner wrapper that JWS and COSE use. This change exports the type to make it available outside of the notation-go repo and additionally adds helper functions for external callers.
The default behavior in the signing path for JWS/COSE when calling generateSignature remains unchanged.