Update CIP-179 indexing and survey support to v5#70
Open
Cerkoryn wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates CGov API’s existing CIP-179 implementation to the stable v5 specification, superseding the earlier implementation introduced in #44.
cip-179package.This API change accompanies the CGov frontend implementation in cgov#132.
Separate Bug Fix
The second commit contains an independent DRep verification fix that is not specific to CIP-179.
Vote ingestion can create an incomplete DRep database record before the regular DRep inventory sync populates its registration data. These incomplete records were previously treated as authoritative, which
could incorrectly disable the governance vote buttons.
The fix refreshes incomplete DRep records from Koios before determining voting eligibility and adds a focused regression test. It is kept in a separate commit so it can be reviewed independently from the
CIP-179 implementation.
Verification
npm run buildnpx jest --runInBand test/cip179-v5.test.ts test/drep-lookup.test.tsnpx prisma validateAll six focused CIP-179 tests and both DRep verification regression tests pass. The Prisma schema is valid.