fix hizuki.rb and translate.rb#156
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/swimmy/service/translate.rbにおいて，使用する環境変数がない場合や環境変数が望ましいものでなかった場合に処理が止まりslack上に何も表示されないようになっていた．これについて，翻訳の失敗として処理してslack上には英字のメッセージと翻訳をできなかった旨を伝える日本語を表示するようにした．
swimmy hizukiの後ろに年や月日を表す引数がない場合，slackj上にhizuki helpの入力を要求するメッセージを表示していた．これについて引数がない場合は，本日の日付に関するメッセージを表示するようにした．