Calendar View for Expenses - #14
Open
subbramanil wants to merge 5 commits into
Open
Conversation
- Adds new ExpenseFragmentModel based off HomeFragmentModel which only has the required functions - Updates FilterExpensesUseCase to compare dates of the two expense items - Adds ExpenseHistoryAdapter with only the required functions to show expenses in rows - Uses simple Linear Layout to show the calendar view & list of expenses (recyclerview) **Note**: ExpenseFragmentModel is added as a redundant for a bit cleaner code. The same functionality can be achieved through few additional functions on "HomeFragmentModel". ExpenseFragmentModel can be removed by removing the comments in 'HomeFragmentModel' and replace usages of 'ExpenseFragmentModel'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for Issue #7
Uses a simple android calendar view and uses existing framework to show the expenses in the calendar view. More info on the commits.
Adding events would require a bit more customization of calendar view or using any existing open source GitHub calendar view libraries with events support.