Rest refactor - #8
Merged
Merged
Conversation
Adds a "Findings from live hardware" section capturing behaviour learned running the shipped integration against the Netgate 6100: - pfRest reports `disabled: false` for rules disabled in the pfSense GUI (strict `=== ''` against pfSense's empty-element form) -- why the rule switches looked backwards, and why there is no client-side fix. - `PATCH /firewall/rule` 400s with FIELD_EMPTY_NOT_ALLOWED on a blank `statetype`; the client backfills "keep state". - `DELETE /api/v2/firewall/states` -- the `source/destination__startswith` prefix filter works, `limit=0` deletes all matches with no per-call cap; resolves the earlier LIVE-CHECK. - Aside on the HACS version-regression trap. Cross-references added in the rule-switch and state-table sections; the stale "no integration code has been rewritten yet" note is corrected. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The Release Drafter workflow was failing because release-drafter@v7 looks for .github/release-drafter.yml and, not finding it here or in nolsen311/.github, 404s. Add a standard label-driven config (breaking-change / feature / bug / maintenance categories, semver version-resolver). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Records that the project began as a fork of DonTranQuiL/Pfsense-pro, was extensively rewritten (XML-RPC -> native async REST API v2) with Claude Cowork, and was de-forked so PRs aren't accidentally opened against upstream. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- README badges pointed at the old repo name and a non-existent pytest.yml workflow: repoint to nolsen311/Pfsense-REST and to the actual workflows (hass-ci.yml, hassfest.yaml, hacs.yaml), pinned to the main branch. - manifest.json documentation / issue_tracker URLs -> Pfsense-REST, so the "Documentation" and "Issues" links on the HA integration page resolve. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Docs and CI-config only since 0.10.0: live-hardware pfRest findings in CLAUDE.md, a release-drafter config, the README fork-origin note, and fixed README badges / manifest documentation+issue_tracker URLs. No runtime change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
🎉 Thank you for contributing to SkyRadar Fusion! Your Pull Request has been received. Our automated tests (Hassfest, Ruff, etc.) will run shortly. If anything fails, don't worry—just check the logs and update your branch! |
- test_setup_and_unload_entry: recent HA requires a coordinator to carry its `config_entry` for `async_config_entry_first_refresh()`, and that call is only valid in SETUP_IN_PROGRESS state. Pass `config_entry=entry` to both DataUpdateCoordinator constructions, and drive the test through `hass.config_entries.async_setup` / `async_unload` instead of calling `async_setup_entry` directly. - test_carp_sensor_on: the CARP Status binary sensor -- the integration's only one -- was `entity_registry_enabled_default=False`, so it never reached the state machine. Enable it by default; it reads harmlessly as off when CARP is not configured. Local `test_pypfsense.py` failures are an aioresponses/aiohttp version mismatch on this machine only; those pass in CI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.10.1
Documentation and CI only — no runtime change.
read back as enabled; blank
statetyperejects a rule PATCH; thefirewall/statesprefix-delete filter behaviour).