fix: forward onResponseStarted through WrapHandler and UnwrapHandler#4840
Merged
metcoder95 merged 1 commit intonodejs:mainfrom Feb 26, 2026
Merged
Conversation
When using `agent.compose()` with interceptors, the handler goes through a WrapHandler → UnwrapHandler round-trip. Neither class forwarded the `onResponseStarted` callback, so `timingInfo.finalNetworkResponseStartTime` was never set and `PerformanceResourceTiming.responseStart` was always 0.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4840 +/- ##
=======================================
Coverage 93.15% 93.15%
=======================================
Files 109 109
Lines 34228 34236 +8
=======================================
+ Hits 31884 31892 +8
Misses 2344 2344 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
N/A
Rationale
When
fetch()goes through a dispatcher with composed interceptors, the handler is wrapped byWrapHandlerand then unwrapped byUnwrapHandler. TheonResponseStartedcallback (which setstimingInfo.finalNetworkResponseStartTime) was not forwarded by either class, causingPerformanceResourceTiming.responseStartto always be0.Changes
Features
N/A
Bug Fixes
onResponseStarted()forwarding toWrapHandler(Unwrap Interface section)onResponseStarted()forwarding toUnwrapHandlerBreaking Changes and Deprecations
N/A
Status