test: enable trace_events tests with perfetto - #66068
Open
legendecas wants to merge 1 commit into
Open
legendecas wants to merge 1 commit into
legendecas wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
legendecas
force-pushed
the
test-perfetto
branch
5 times, most recently
from
September 16, 2026 15:37
1f5ce76 to
9ace27c
Compare
Member
I think this (the download bit) will cause issues for downstream rebuilders cc @nodejs/distros. |
legendecas
force-pushed
the
test-perfetto
branch
from
September 16, 2026 16:26
9ace27c to
db7f4b5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66068 +/- ##
==========================================
+ Coverage 90.23% 90.26% +0.03%
==========================================
Files 789 789
Lines 270613 271482 +869
Branches 51794 51816 +22
==========================================
+ Hits 244178 245058 +880
+ Misses 16916 16887 -29
- Partials 9519 9537 +18 🚀 New features to boost your workflow:
|
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
legendecas
force-pushed
the
test-perfetto
branch
from
September 16, 2026 18:44
db7f4b5 to
126bad1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use https://perfetto.dev/docs/reference/trace-processor-cli to
convert the perfetto binary trace files to JSON files in tests
to verify that the traces are correctly exported with perfetto.
This moves the
trace_eventstest suite to a dedicated testfolder
test/trace_eventsas they depend on an external tooltrace_processor_shell. Added amake trace_processortodownload the expected version of
trace_processor_shellfrom perfetto releases.
This also unified the test assertions so that a test can
verify both legacy traces and perfetto traces.
Refs: #65794 (comment)