Skip to content

test: accept ENOTEMPTY from libc++ in test-fs-rm #66065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codebytere wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −4
Open

test: accept ENOTEMPTY from libc++ in test-fs-rm #66065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions test/parallel/test-fs-rm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,10 +490,9 @@ if (isGitPresent) {
// This test should not be run as `root`
if (!common.isIBMi && (common.isWindows || process.getuid() !== 0)) {
function makeDirectoryReadOnly(dir, allowExecute) {
let accessErrorCode = 'EACCES';
if (common.isMacOS && allowExecute) {
accessErrorCode = 'ENOTEMPTY';
}
// With libc++ before LLVM 23 remove_all() reports the parent's ENOTEMPTY
// over the child's EACCES: https://github.com/llvm/llvm-project/pull/197104
let accessErrorCode = allowExecute ? /^(EACCES|ENOTEMPTY)$/ : 'EACCES';
if (common.isWindows) {
accessErrorCode = 'EPERM';
const permissions = ['DE', 'DC'];
Expand Down
Loading