Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
module
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
Signed-off-by: dansatch <dansatch98@gmail.com>
Dansatch
force-pushed
the
fix-package-map-directory-urls
branch
from
September 16, 2026 03:55
e21d359 to
40dc850
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66043
Package-map URLs ending with a slash, including
".."and"./", are stored differently from the paths used during lookup. This causes valid dependencies to fail withERR_PACKAGE_MAP_EXTERNAL_FILE.This change normalizes package paths when the map is loaded. Tests cover CommonJS, ESM, parent-directory URLs, trailing slashes, and duplicate paths.
The bug was reproduced on Node.js v26.8.2.