Conversation
Signed-off-by: hanityx <hanityx@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66040 +/- ##
==========================================
- Coverage 90.23% 90.22% -0.01%
==========================================
Files 785 789 +4
Lines 269670 270614 +944
Branches 51589 51798 +209
==========================================
+ Hits 243325 244150 +825
- Misses 16825 16933 +108
- Partials 9520 9531 +11
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CR and CRLF from custom serializers such as
Stringare written unescaped intosnapshot template literals and normalized to LF when the file is evaluated.
The default JSON serializer is unaffected.
For example, in JavaScript string notation:
An unchanged value therefore fails comparison, while changing only the line
endings to LF can incorrectly pass.
Escape carriage returns in snapshot values and add CR/CRLF round-trip tests.
Existing snapshots containing unescaped CR values will still have those CRs
normalized to LF when evaluated until they are regenerated with
--test-update-snapshots