deps: V8: respect interceptors in lexical restricted-global check

deps/v8/include/v8-version.h

@@ -11,7 +11,7 @@
 #define V8_MAJOR_VERSION 14
 #define V8_MINOR_VERSION 6
 #define V8_BUILD_NUMBER 202
-#define V8_PATCH_LEVEL 34
+#define V8_PATCH_LEVEL 35
 
 // Use 1 for candidates and 0 otherwise.
 // (Boolean macro values are not supported by all preprocessors.)

deps/v8/src/execution/execution.cc

@@ -231,12 +231,12 @@ MaybeDirectHandle<Context> NewScriptContext(
 
     if (IsLexicalVariableMode(mode)) {
       LookupIterator lookup_it(isolate, global_object, name, global_object,
-                               LookupIterator::OWN_SKIP_INTERCEPTOR);
+                               LookupIterator::OWN);
       Maybe<PropertyAttributes> maybe =
           JSReceiver::GetPropertyAttributes(&lookup_it);
-      // Can't fail since the we looking up own properties on the global object
-      // skipping interceptors.
-      CHECK(!maybe.IsNothing());
+      // The interceptor query callback may throw, in which case propagate the
+      // pending exception instead of continuing.
+      if (maybe.IsNothing()) return MaybeDirectHandle<Context>();
       if ((maybe.FromJust() & DONT_DELETE) != 0) {
         // ES#sec-globaldeclarationinstantiation 5.a:
         // If envRec.HasVarDeclaration(name) is true, throw a SyntaxError

test/parallel/test-vm-global-property-interceptors.js

@@ -127,3 +127,26 @@
 'use strict';
 Object.defineProperty(this, 'f', { value: 'newF' });
 `, ctx), /TypeError: Cannot redefine property: f/);
+
+{
+  const restrictedCtx = vm.createContext({});
+  vm.runInContext(
+    "Object.defineProperty(this, 'foo', { value: 1, configurable: false });",
+    restrictedCtx);
+  assert.throws(() => vm.runInContext('let foo;', restrictedCtx), {
+    name: 'SyntaxError',
+    message: /Identifier 'foo' has already been declared/,
+  });
+  assert.throws(() => vm.runInContext('const foo = 2;', restrictedCtx), {
+    name: 'SyntaxError',
+    message: /Identifier 'foo' has already been declared/,
+  });
+
+  // A configurable global property does not restrict a lexical declaration.
+  const configurableCtx = vm.createContext({});
+  vm.runInContext(
+    "Object.defineProperty(this, 'bar', { value: 1, configurable: true });",
+    configurableCtx);
+  assert.doesNotThrow(() => vm.runInContext('let bar = 9; bar;',
+                                            configurableCtx));
+}