Skip to content

stream: remove transform-writer handling in pipeTo#63684

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:stream-iter-pull-transform-writer-handling
Open

stream: remove transform-writer handling in pipeTo#63684
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:stream-iter-pull-transform-writer-handling

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented May 31, 2026

Remove unreachable transform-writer handling from stream/iter pipeTo() and
pipeToSync().

The argument parser already requires the final non-options argument to be a
writer (write for pipeTo(), writeSync for pipeToSync()). Treating that
same object as a transform when it also has transform() does not match the
documented pipeTo(source, ...transforms, writer, options?) argument shape.

Fixes: #63683


Assisted-by: openai:gpt-5.5

The pipeTo() and pipeToSync() argument parser already requires the
destination argument to be a writer. Remove the later transform-writer
handling so writer objects with a transform() method are treated only
as destinations.

Fixes: nodejs#63683

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: openai:gpt-5.5
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels May 31, 2026
@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (9e58d9d) to head (7a89e5c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63684      +/-   ##
==========================================
- Coverage   90.34%   90.33%   -0.02%     
==========================================
  Files         732      732              
  Lines      236507   236497      -10     
  Branches    44531    44526       -5     
==========================================
- Hits       213684   213629      -55     
- Misses      14525    14584      +59     
+ Partials     8298     8284      -14     
Files with missing lines Coverage Δ
lib/internal/streams/iter/pull.js 88.59% <ø> (+0.47%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trivikr trivikr requested a review from jasnell June 3, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stream: pipeTo treats writer transform() method as pipeline transform

2 participants