-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
src: throw RangeError on failed ArrayBuffer BackingStore allocation #61480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
legendecas
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
legendecas:arraybuffer-allocate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates `ERR_MEMORY_ALLOCATION_FAILED` to be a RangeError, aligning with V8's OutOfMemory error type.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61480 +/- ##
==========================================
+ Coverage 89.85% 89.86% +0.01%
==========================================
Files 665 665
Lines 203290 203309 +19
Branches 39081 39088 +7
==========================================
+ Hits 182667 182710 +43
+ Misses 12977 12945 -32
- Partials 7646 7654 +8
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Jan 22, 2026
Member
addaleax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Collaborator
cjihrig
approved these changes
Jan 23, 2026
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates
ERR_MEMORY_ALLOCATION_FAILEDto be a RangeError,aligning with V8's OutOfMemory error type and ECMAScript's OutOfMemory
error type.
There are still many call sites in crypto, tls and quic need to be reviewed
to properly handle the failed ArrayBuffer BackingStore allocation. This
PR updates call sites not in these modules.
Refs:
node/deps/v8/src/builtins/builtins-typed-array.cc
Line 584 in c755b01
Refs: https://tc39.es/ecma262/#sec-sharedarraybuffer.prototype.grow
Refs: #61403 (comment)