Skip to content

Conversation

@joyeecheung
Copy link
Member

This prevents clobbering the stack traces with another internal frame and removes the unnecessary hoops from step-debugging.

This prevents clobbering the stack traces with another internal
frame and removes the unnecessary hoops from step-debugging.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Jan 22, 2026
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.87%. Comparing base (e9b0849) to head (e06bcd0).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61479      +/-   ##
==========================================
- Coverage   91.93%   89.87%   -2.06%     
==========================================
  Files         343      665     +322     
  Lines      139636   203296   +63660     
  Branches    22026    39081   +17055     
==========================================
+ Hits       128369   182713   +54344     
- Misses      11040    12929    +1889     
- Partials      227     7654    +7427     
Files with missing lines Coverage Δ
lib/internal/modules/cjs/loader.js 98.16% <100.00%> (+18.70%) ⬆️

... and 453 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2026
@nodejs-github-bot
Copy link
Collaborator

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2026
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants