Skip to content

gyp: aix: change gcc version so CXX="ccache g++" works #61464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sxa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gyp: aix: change gcc version so CXX="ccache g++" works #61464

sxa wants to merge 1 commit into from
+1 −1

Conversation

@sxa
Copy link
Member

@sxa sxa commented Jan 21, 2026

Closes #61443

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 21, 2026

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jan 21, 2026
@sxa
Copy link
Member Author

sxa commented Jan 21, 2026

I've done a quick test of this with setting CXX to ccache g++ and leaving it unset so it defaults to g++ and it looks ok (based on looking at the first few lines from make showing the expected values, and the libpath parameter being correct in one of the generated .mk files)

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 21, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70943/

@sxa
gyp: aix: change gcc version detection so CXX="ccache g++" works
b606fd7 
Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa
Copy link
Member Author

sxa commented Jan 21, 2026

(Force push purely to add "detection" to the commit title)

@sxa sxa requested a review from richardlau January 21, 2026 16:20
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 21, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70946/

@sxa sxa self-assigned this Jan 22, 2026
@sxa sxa marked this pull request as ready for review January 22, 2026 16:12
@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@anonrig anonrig anonrig approved these changes

@richardlau richardlau richardlau approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees

@sxa sxa

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AIX configure can't handle CC="ccache gcc"

6 participants

@sxa @nodejs-github-bot @addaleax @anonrig @richardlau @juanarbol