Ensure hooks and plugins are included in the mock runtime api#74
Open
Ensure hooks and plugins are included in the mock runtime api#74
Conversation
Member
Author
|
Initial testing suggests more is needed. Parking for now - will merge/release with #73 to unblock some other work that is happening and come back to this another day. |
|
Just tried this locally, and |
|
Mentioned that it should have been Even with this, we then see different behaviour to core: Test Helper:
Node-RED Core:
|
Member
Author
|
@joepavitt that is odd. Can't see anything async in either code path that would result in a promise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative fix to #73 - rather than stub it, expose the real internal plugin api.