Avoid copying DWG object memory stream#3
Open
Michaelliv wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids repeated full-buffer copies while reading DWG objects.
DwgObjectReaderstores_memoryStreamas aUint8Array, but several hot-path calls passednew Uint8Array(this._memoryStream)toDwgStreamReaderBase.getStreamHandler(...). That creates a copy of the full object stream every time object metadata is read.On a 4.6MB AC1032 DWG, this caused
DwgReader.readFromStream()to time out after 180s locally with heavy allocation/GC. Passing the existing_memoryStreamview directly reduced the same read to ~2.6s.Validation:
Fixes #2.