Add a bind to move the workspaces up and down. - #10
Open
Yocraft-2000 wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
Allowing the trailing workspace to move since that's how it works in niri. |
Member
|
Hey @Yocraft-2000 , looks good overall, but I think this needs a couple of changes before merging:
The swap and metadata refresh approach otherwise looks sensible. Also of course the conflicts need to be resolved :). |
Yocraft-2000
force-pushed
the
move-workspace-bind
branch
from
August 23, 2026 13:59
6d5c659 to
26c82d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
workspace-move-upandworkspace-move-downbinds.Motivation
These binds exist in niri and I miss them in umbriel.
Type of Change
Related Issue
None.
Testing
The trailing empty workspace is ignored.
Manual Coverage
Screenshots / Videos
Checklist
CONTRIBUTING.md.just format, or this PR has no C++ changes.docs/andexamples/config.toml, or this PR does not change user-facing configuration or behavior.Additional Notes