feat: add fzf template - #90
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This template does not include a post hook to automatically apply the theme. Since FZF theming is shell-specific and configured through environment variables, users may have very different shell setups—rather than a plain
.zshrc, for example, some may use lazy loading or other custom initialization logic.It is therefore better not to make that decision for users. This PR respects any existing
FZF_DEFAULT_OPTSvalue and only appends the color-related options to it.The template should generate the theme options in:
~/.config/fzf/themes/noctalia.sh~/.config/fzf/themes/noctalia.fishUsers are then responsible for sourcing the appropriate file from their own shell configuration.
Because this requires manual setup, we should also add an entry to the documentation website under the Community Templates section. If this PR is approved, I will open a documentation PR for that shortly afterward.
Here is a demo:
Catppuccin Dark
Nord Dark
Rosé Pine Light