Skip to content

fix(color_picker) set runAsync timeout to 60sec - #442

Open
tordex wants to merge 1 commit into
noctalia-dev:mainfrom
tordex:color_picker
Open

fix(color_picker) set runAsync timeout to 60sec#442
tordex wants to merge 1 commit into
noctalia-dev:mainfrom
tordex:color_picker

Conversation

@tordex

@tordex tordex commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Plugin

  • Id: oldirtty/color_picker
  • New plugin
  • Update to an existing plugin (version bumped in plugin.toml)

What it does

runAsync is called without timeout argument, so we have only 5 seconds to select the color. I've set timeout to the 60sec to give more time.

External dependencies

Requires hyprpicker

Testing

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Noctalia version tested against: 5.0.0_beta9
  • Plugin API level: 9

Screenshots / Videos

Checklist

Ready-for-review requirement: Every box in this section must be checked. If any statement is not true, keep the
pull request as Draft. An explanation does not replace a required check.

  • The directory name matches the part of id after the / in plugin.toml exactly.
  • It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
  • README.md follows the
    README template, documents
    every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
  • I created thumbnail.webp with the thumbnail generator.
  • version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
  • Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and
    understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
  • I did not edit catalog.toml; CI generates it.
  • This PR touches exactly one plugin directory.

Code review attestation

Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
Ready-for-review requirement: Every attestation below must be checked.

  • The code is readable and not obfuscated, minified, or generated.
  • It does not download and execute remote code.
  • Every network call, filesystem write, and spawned process is something the description above accounts for.
  • I have the right to publish this code under the license declared in plugin.toml.

@github-actions

Copy link
Copy Markdown
Contributor

CC @oldirtty

@oldirtty

Copy link
Copy Markdown
Contributor

This is great, thanks! I actually wanted to do exactly this when I first wrote the plugin, but back then the community plugins repo hadn't launched yet, so I don't remember having this functionality available at the time.

@ItsLemmy since this PR removes the time limitation, the ## Notes section in the plugin's README.md should be removed too. Happy to do it myself if that's easier, or @tordex can fold it into this PR, whichever's more convenient.

@tordex

tordex commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

@oldirtty, actually time limitation was not removed by this PR. Just expanded it from 5sec to 60sec. So, I guess, the Notes section should not be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants