fix(color_picker) set runAsync timeout to 60sec - #442
Open
tordex wants to merge 1 commit into
Open
Conversation
Contributor
|
CC @oldirtty |
Contributor
|
This is great, thanks! I actually wanted to do exactly this when I first wrote the plugin, but back then the community plugins repo hadn't launched yet, so I don't remember having this functionality available at the time. @ItsLemmy since this PR removes the time limitation, the ## Notes section in the plugin's README.md should be removed too. Happy to do it myself if that's easier, or @tordex can fold it into this PR, whichever's more convenient. |
Contributor
Author
|
@oldirtty, actually time limitation was not removed by this PR. Just expanded it from 5sec to 60sec. So, I guess, the Notes section should not be removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin
oldirtty/color_pickerplugin.toml)What it does
runAsync is called without timeout argument, so we have only 5 seconds to select the color. I've set timeout to the 60sec to give more time.
External dependencies
Requires hyprpicker
Testing
Screenshots / Videos
Checklist
Ready-for-review requirement: Every box in this section must be checked. If any statement is not true, keep the
pull request as Draft. An explanation does not replace a required check.
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.README.mdfollows theREADME template, documents
every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
thumbnail.webpwith the thumbnail generator.versionfollows semver and is bumped in this PR;plugin_apiis the oldest API level this plugin requires.understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
catalog.toml; CI generates it.Code review attestation
Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
Ready-for-review requirement: Every attestation below must be checked.
licensedeclared inplugin.toml.