chore(deps): batch upgrade โ vite (security), AWS SDK, @types/node#102
Merged
Conversation
Adds a worker-local override to pull vite up from 7.3.1 โ 7.3.5, covering GHSA-4w7w-66w2-5vf9 (path traversal in .map handling), GHSA-p9ff-h696-f583 (arbitrary file read via dev server WebSocket), and GHSA-v2wj-q39q-566r (server.fs.deny bypass via queries). vite is only pulled in transitively through vitest in the worker workspace; pinned to ^7.3.2 to stay on the same major as vitest 4 peerDeps and avoid the vite 8 jump. Root already runs vite 8.0.16 and is not affected. All 72 worker vitest specs pass. Refs #101
cli was on @types/node ^22.0.0 and resolved to 22.19.20; pinned to 25.9.3 to align with root and match what the issue requested. Refs #100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch dependency upgrade rolled into one branch with three atomic commits.
4c96528worker: add localoverrides.vite: ^7.3.2to pull transitivevitefrom7.3.1โ7.3.5. Covers GHSA-4w7w-66w2-5vf9, GHSA-p9ff-h696-f583, GHSA-v2wj-q39q-566r.736a05broot:@aws-sdk/client-s3+@aws-sdk/s3-request-presigner3.1065.0โ3.1066.0.1eea3deroot+cli:@types/nodeโ25.9.3(cli aligned from^22.0.0to25.9.3to match root).vite โ why
overrides, not a direct depviteis only pulled in transitively throughvitest@4.1.8in theworkerworkspace; the project itself doesn't import it.bun add vitewould (and did, in a discarded attempt) elevate it to a direct dependency, which doesn't match the GitHub issue's "transitive" classification. The^7.3.2pin keeps the resolved version inside vitest 4'svitepeer range (^6.0.0 || ^7.0.0 || ^8.0.0) and avoids the unnecessary blast radius of jumping to vite 8. Root still runsvite@8.0.16and is unaffected.Test plan
Local on the agent workspace (this machine):
worker/bun run testโ 72/72 passed (now onvite@7.3.5)bun x tsc --noEmitโ exit 0bun run test:unitโ 2445/2445 passedcli/bun run testโ 136 passed / 1 skippedbun install --frozen-lockfile --ignore-scriptsโ clean (re-run by Reviewer)bun install --frozen-lockfile --ignore-scriptsโ clean (re-run by Reviewer)bun install --frozen-lockfile --ignore-scriptsโ clean (re-run by Reviewer)bun run test:api) โ skipped locally: this agent workspace has no.env.localand therefore noD1_TEST_DATABASE_ID/D1_TEST_PROXY_URL/D1_TEST_PROXY_SECRET, so the pre-push hook can't bring up the test D1 binding. CI has the D1 secrets configured and runsbun run test:apias the safety net. This push used--no-verifysolely to bypass that local-only blocker (authorized for this branch, narrow scope).osv-scanner(pre-push side) โ clean, no new vulns introduced.Reviewer-01 verdict
Reviewer-01 independently re-ran
bun install --frozen-lockfile --ignore-scriptsfor root/cli/worker plus root tsc/test:unit, worker test, cli test โ all green. Confirmedviteresolves to7.3.5(inside the vitest 4 peer range), AWS SDK is a same-family patch bump, and the worker rollup/postcss/nanoid lockfile churn is just transitive carry-along from the newvite 7.3.5.clilint โ pre-existing, NOT introduced herecli/bun run lint(which runstsc --noEmit && biome check src/) reports 4 Biome formatting /import-typeerrors incli/src/.tsc --noEmititself passes. These errors reproduce onmain(verified viagit stashbefore this PR), are entirely in files this PR doesn't touch, and are outside the scope of a pure dependency-version bump. Not fixed here โ should be a separate cleanup PR if desired.Closes