fix(deps): override esbuild ^0.28.1 to clear OSV advisories#78
Merged
Conversation
drizzle-kit 0.31.10 and tsx 4.21.0 still pull in vulnerable esbuild 0.25.12/0.27.7 transitively, triggering GHSA-gv7w-rqvm-qjhr (High, Deno RCE) and GHSA-g7r4-m6w7-qqqr (Low, Windows path traversal) on OSV scans. Neither upstream has shipped a fixed release yet. Pin esbuild to ^0.28.1 via bun overrides so every transitive resolution lands on the patched version. With that pin the previous ignore for GHSA-67mh-4wv8-2f99 (@esbuild-kit/core-utils) is no longer reachable, so osv-scanner.toml is emptied. Verified: bun run lint, typecheck, test (945 passing), build, and osv-scanner --lockfile=bun.lock (no issues found).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esbuildto^0.28.1via rootpackage.jsonoverrides. drizzle-kit 0.31.10 still requires^0.25.4and tsx 4.21.0 requires~0.27.0, both of which resolved to vulnerable releases (0.25.12 / 0.27.7). Neither upstream has shipped a fix yet, so an override is the smallest unblock and gets every transitive resolution onto 0.28.1.GHSA-67mh-4wv8-2f99ignore — the override also clears the@esbuild-kit/core-utilspull-through that the previous ignore was working around, soosv-scanner.tomlis empty.Advisories cleared
drizzle-kit → esbuild@0.25.12,tsx → esbuild@0.27.7tsx → esbuild@0.27.7@esbuild-kit/core-utils → esbuild@0.18.20(previously ignored)This unblocks PR #77 (
quality / L1+G1+G2was failing on these advisories) and restores green onmain.Test plan
bun install→ 800 packages, no resolution conflictsbun pm ls --all | grep esbuild→ every esbuild copy is now0.28.1bun run lintcleanbun run typecheckcleanbun run test→ 945 passing (71 files)bun run buildsucceedsosv-scanner scan source --lockfile=bun.lock→ no issues founddrizzle-kit generate --helploads (sanity check that the bumped esbuild still satisfies drizzle-kit's runtime use of the API)