Repository navigation
Conversation
The frameless window draws a hairline edge (a border plus an inset ring) so it stands apart from whatever is behind it. On desktops that already separate windows well, such as KDE Plasma with a dark wallpaper, that line reads as a stray white border around the app. "Window outline" in Settings > Window turns it off. It defaults to on, so nothing changes for anyone who does not touch it, and it is hidden under OS native decorations, where the outline is already dropped.
The window geometry was saved with outerSize but restored with setSize, which sets the inner size. With a frameless window the two are the same, but with OS native decorations the window grew by the height of the frame on every launch. It now saves the inner size, so both sides measure the same thing.
The switch lived on the Library tab, under "Cache and local files", where nobody looking for what the close button does would find it. It now sits on the Window tab, right below the window controls, since it decides what the close button does. The settings search entry moves with it.
|
@zebus3d is attempting to deploy a commit to the Faizan Asad's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Three small window-related changes, one commit each, so any of them can be taken on its own:
outerSize()but restored withsetSize(), which sets the inner size. With a frameless window the two are the same, but with OS native decorations the window grew by the height of the frame on every launch. It now savesinnerSize().How it was checked
npm run verifypassesNotes for the reviewer
Frontend only, no Rust changes.