Repository navigation
Conversation
The skinned mini players already turn the wheel into volume, but the classic capsule ignored it. Its only way to change volume was to switch the hover bar from song position to volume in Settings, which means giving up seeking. The wheel now controls volume on the classic skin too, with the same proportional step as the skins. The artist line briefly shows the new level, so a wheel turn has feedback even when the hover bar is the song position.
Closing the mini player only hides it until the main window is next backgrounded. That is right for "not now", but the only way to say "never" was the switch in Settings > Window, which is hard to find from the mini player. A right-click menu now offers both "Hide for now" and "Don't show again". On the classic skin it opens from the close button, because a right-click anywhere else on the capsule drags the window; the other skins open it from anywhere. "Don't show again" only flips the existing setting, and the main window reacts to that as it does when the switch is turned off in Settings.
The mini player window is always as tall as the expanded capsule, and the capsule sits at the bottom of it and grows upward. That suits the default spot near the bottom of the screen. In the top half, though, the spare room sits above the pill and keeps it from reaching the top edge. The capsule now anchors to whichever half of the monitor the window is in. In the top half it sits at the top of the window and grows downward. The Windows-only hover hit-test follows the same anchor.
|
@zebus3d is attempting to deploy a commit to the Faizan Asad's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Three small improvements to the mini player, one commit each, so any of them can be taken on its own:
Volume N%as feedback.mini-player-enabledsetting, and the main window reacts exactly as when the switch is turned off.How it was checked
npm run verifypassesNotes for the reviewer
Tested on Linux only. The hit-test change for the top anchor is in the Windows-only hover poll, so it would be worth a quick look on Windows. The native menu uses
@tauri-apps/api/menu, covered bycore:default.