docs(http): document observer root semantics for scroll/visible triggers - #73
Merged
Conversation
The IntersectionObservers for get-trigger="scroll", get-trigger="visible", and the initial-request observer resolve the nearest scrollable ancestor (overflow-y: auto|scroll) as observer root, falling back to the viewport. Document this behavior and the fill-until-overflow semantics in references/directives/http.md and SKILL.md.
ErickXavier
commented
Aug 4, 2026
ErickXavier
left a comment
ErickXavier
left a comment
Collaborator
Author
There was a problem hiding this comment.
Code review
No issues found. Checked for bugs and CLAUDE.md compliance.
Verified documentation claims against NoJS/src/directives/http.js:
_findScrollContainersemantics (overflow-y walk, documentElement fallback)- Observer root mapping (
documentElementtonullfor viewport) - All three observer call sites use
_findScrollContainer - Fill-until-overflow behavior description
- Commit message format, branch naming, no attribution trailers, no version bump
… wording Update data-fetching.md: replace three stale "viewport" references with scroll-container semantics, add cross-reference to http.md get-threshold section. Adjust http.md observer-root paragraph to clarify the scroll-without-insert path is a fallback, not a third coequal observer.
This was referenced Aug 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the IntersectionObserver root resolution behavior for all three observers in the get/pagination system:
get-trigger="scroll"sentinel observer (http.js L824-835)get-trigger="visible"observer (http.js L882-894)All three call
_findScrollContainer(el)(http.js L49-57), which walks up the DOM checking computedoverflow-yforautoorscroll, falling back todocument.documentElement. The result is passed as the IntersectionObserver root (documentElementmaps tonull= viewport).Changes
references/directives/http.md: Fixed "viewport" references in theget-triggertable to say "scroll container". Added Observer root and Fill-until-overflow notes in theget-thresholdsection explaining the root resolution and the fill-until-overflow behavior. Updated example comment.SKILL.md: Added one-line mention of observer root semantics and fill-until-overflow to the Pagination summary line.Verification
NoJS/src/directives/http.jslines 49-57, 824-835, 882-894, 910-921.Refs #72