chore(release): bump version to 1.20.0 - #70
Conversation
ErickXavier
left a comment
There was a problem hiding this comment.
APPROVED — QA GATE (T8, EPIC NOJS-270)
Scope verified: markdown-only version bump 1.19.0 → 1.20.0. HELD note present in PR body (do not merge until v1.20.0 release, T10).
Evidence
gh pr diff 70confirms exactly ONE changed line:nojs/SKILL.mdfrontmattermetadata.version: 1.19.0→1.20.0(line 4). No other files touched.- YAML frontmatter remains well-formed (version correctly nested under
metadata:, parses as string). - Code review (multi-angle): no findings. No other version references exist in the repo (no README badge, no manifest) — SKILL.md frontmatter is the sole version location per workspace convention.
- Commit
062cecaconventional (chore(release): bump version to 1.20.0), author/committer Erick Xavier, no trailers, no AI attribution in commit or PR body. - Ecosystem parity confirmed: nojs#290, nojs-elements#74, nojs-lsp#81 all at 1.20.0.
Non-blocking notes
- CHANGELOG [1.20.0] entry deferred to T9 — expected.
|
Appended changelog commit (b1e0471): |
ErickXavier
left a comment
There was a problem hiding this comment.
APPROVED — QA GATE (T9)
Reviewed commit b1e0471 on chore/NOJS-278-version-bump (CHANGELOG v1.20.0 entry + SKILL.md frontmatter bump, 2 commits total on branch).
Verification evidence
- Both [1.20.0] bullets verified true against held PR #69's diff (427 lines): it touches exactly
nojs/SKILL.md(SSE section with the full attribute table listed) andnojs/references/directives/sse.md— the two files the changelog names. - CHANGELOG format matches prior entries: em-dash heading, tag-based compare links ([Unreleased] → v1.20.0...HEAD, entry → v1.19.0...v1.20.0),
### Addedsection, date 2026-07-17. - Diff scope clean: CHANGELOG.md + SKILL.md frontmatter version line only. Zero stale 1.19.0 references introduced.
- Commits conventional, author Erick Xavier, no attribution trailers.
- Full 8-angle code-review pipeline: zero blocking defects.
Merge-order dependency (important for T10)
This changelog describes content shipped by held PR #69. Both must merge before the v1.20.0 tag; either order works, but tagging without #69 merged would make this entry false.
Should-fix before the v1.20.0 tag (non-blocking, pre-existing)
.claude-plugin/plugin.jsonis still"version": "1.16.1"(last aligned in cb2ffb6; missed since v1.17.0). This repo's CONTRIBUTING.md Version Sync Checklist (lines 102-109) requires plugin.json to be bumped in the same commit as the SKILL.md frontmatter. Recommend appending a one-line 1.16.1 → 1.20.0 bump to this branch — release step 16 (verify versions match) would otherwise keep failing for plugin/marketplace consumers.- Pre-existing staleness in SKILL.md body (follow-up material, untouched by this PR): line 543
NoJS.version // "1.15.0"and line 670| **Version** | 1.15.0 |.
|
Appended commit 277af78: sync plugin.json version 1.16.1 → 1.20.0. |
Summary
Status
HELD — do not merge until v1.20.0 release (T10)