Redesign key quantity extraction/insertion pipeline#205
Open
sbreitbart-NOAA wants to merge 2 commits intomainfrom
Open
Redesign key quantity extraction/insertion pipeline#205sbreitbart-NOAA wants to merge 2 commits intomainfrom
sbreitbart-NOAA wants to merge 2 commits intomainfrom
Conversation
…eline to add kqs to it in landings plot
Contributor
New version checklist
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we've redesigned the figures and tables to be more flexible on the user's end (i.e., they can more powerfully customize what their plots show by specifying plot arguments), the existing pipeline to extract key quantities and then insert them into the captions/alt text template doesn't work for several quantities anymore. Basically, key quantities need to reflect the users' data summarization, grouping specifications, filtering, etc.
To fix this, I've begun redesigning this pipeline so that key quantities are:
write_captions(), and then the remainders withadd_more_key_quants())This pipeline should also resolve issues of key quantity calculation dependency, where the calculation of one kq depends on the prior calculation of another. If they're all calculated and stored in a single place, all can be referenced for future calculations of other quantities.
This will also facilitate sharing the kqs with SIS.
Ultimately,
write_captions()andadd_more_key_quants()should become redundant and removed.@Schiano-NOAA I've just made a pilot draft focused on
plot_landings(), which was a simple example. Could you please take a look and let me know if this is on the right track?