Skip to content

Update SAFE template table structure from flextable to asar#432

Merged
sbreitbart-NOAA merged 3 commits intodevfrom
safe-gt
Mar 10, 2026
Merged

Update SAFE template table structure from flextable to asar#432
sbreitbart-NOAA merged 3 commits intodevfrom
safe-gt

Conversation

@sbreitbart-NOAA
Copy link
Collaborator

What is the feature?

How have you implemented the solution?

  • see above

Does the PR impact any other area of the project, maybe another repo?

  • No

@sbreitbart-NOAA sbreitbart-NOAA linked an issue Mar 5, 2026 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Checklist

  • PR base branch is accurate
  • Is the code concise?
  • Comments are clear and useful.
  • Can you remove or combine any arguments?
  • Do argument contain defaults (if appliable)?
  • Code is documented and example provided (Roxygen).
  • Did you make a test (testthat)?
  • Was this tested under multiple scenarios?
  • Did you run devtools::check()?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Code Metrics Report

Coverage Code to Test Ratio Test Execution Time
37.1% 1:0.2 29s

Reported by octocov

Copy link
Collaborator

@Schiano-NOAA Schiano-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Were you able to test it or no since there's no example data here?

@sbreitbart-NOAA
Copy link
Collaborator Author

Looks good! Were you able to test it or no since there's no example data here?

I tested it with the sample data from Ben's {safe} package, which was already in these files. It worked fine, since I just swapped the flextable for the gt package. But I didn't update the tables to work with stockplotr's converted model output (which won't be compatible). Should I merge this PR and then create a new task to update these tables to be compatible with the converted output, esp. since you're close to finishing the Rceattle work?

@Schiano-NOAA
Copy link
Collaborator

Yes! Good idea

@sbreitbart-NOAA sbreitbart-NOAA merged commit c12a46d into dev Mar 10, 2026
3 checks passed
@sbreitbart-NOAA sbreitbart-NOAA deleted the safe-gt branch March 10, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: flextable still present in SAFE report template

2 participants