Update SAFE template table structure from flextable to asar#432
Merged
sbreitbart-NOAA merged 3 commits intodevfrom Mar 10, 2026
Merged
Update SAFE template table structure from flextable to asar#432sbreitbart-NOAA merged 3 commits intodevfrom
sbreitbart-NOAA merged 3 commits intodevfrom
Conversation
Contributor
Checklist
|
Contributor
Code Metrics Report
Reported by octocov |
Schiano-NOAA
approved these changes
Mar 6, 2026
Collaborator
Schiano-NOAA
left a comment
There was a problem hiding this comment.
Looks good! Were you able to test it or no since there's no example data here?
Collaborator
Author
I tested it with the sample data from Ben's {safe} package, which was already in these files. It worked fine, since I just swapped the flextable for the gt package. But I didn't update the tables to work with stockplotr's converted model output (which won't be compatible). Should I merge this PR and then create a new task to update these tables to be compatible with the converted output, esp. since you're close to finishing the Rceattle work? |
Collaborator
|
Yes! Good idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the feature?
How have you implemented the solution?
Does the PR impact any other area of the project, maybe another repo?