use "source" for source names#379
Open
fricklerhandwerk wants to merge 1 commit intonmattia:masterfrom
Open
Conversation
this removes a difference to how Nix currently fetches flake references. using a constant is preferrable because renaming the source won't force downstream rebuilds. there probably is no correct solution here, as any choice for the symbolic name is essentially arbitrary, and arguably symbolic names were an unfortunate design decision anyway.
fricklerhandwerk
force-pushed
the
source-name
branch
from
d38978d to
e680cd8
Compare
fricklerhandwerk
added a commit
to fricklerhandwerk/nix.dev
that referenced
this pull request
Nov 7, 2023
this removes a difference to how Nix currently fetches flake references. using a constant is preferrable because renaming the source won't force downstream rebuilds of store objects cached from when flakes were used. upstream fix: nmattia/niv#379
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this removes a difference to how Nix currently fetches flake references.
using a constant is preferrable because renaming the source won't force downstream rebuilds.
there probably is no correct solution here, as any choice for the
symbolic name is essentially arbitrary, and arguably symbolic names were
an unfortunate design decision anyway.
@infinisil @Ericson2314