Repository navigation
otra: drop unused base parameter from parse_otra_tables - #54
Merged
Merged
Conversation
`parse_otra_tables` never read `base`: `parse_otra` folds it into `h.part_off`, `h.seg_off`, and `h.pay_off`, so the tables are already absolute. The parameter only produced `-Wunused-parameter` warnings in every translation unit that includes `otra_format.hpp`. Remove the parameter and update both call sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building moria emits the same warning from every translation unit that includes
src/otra_format.hpp:parse_otra_tablesnever readsbase.parse_otraalready folds it intoh.part_off,h.seg_off, andh.pay_off(otra_format.hpp:108-110), so the tables the function walks are absolute. This drops the parameter and updates the two call sites.No behavior change.
ctestpasses 29/29.