Skip to content

Drop the port from remote-derived hosts so glab --hostname accepts them #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 2 commits into from
Aug 31, 2026
Merged

Drop the port from remote-derived hosts so glab --hostname accepts them #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1391a86
Drop the port from remote-derived hosts so glab --hostname accepts them
oskarnyc Aug 30, 2026
cde19d1
Limit port stripping to ssh:// remotes
oskarnyc Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion electron/__tests__/review-source.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ import { expect, test } from 'vite-plus/test';

const require = createRequire(import.meta.url);

const { parseReviewUrl } = require('../review-source.cjs') as {
const { parseRemoteUrl, parseReviewUrl } = require('../review-source.cjs') as {
parseRemoteUrl: (value: string) => {
host: string;
projectPath: string;
provider: 'github' | 'gitlab';
} | null;
parseReviewUrl: (value: string) => {
host: string;
number: number;
Expand Down Expand Up @@ -129,3 +134,32 @@ test('parseReviewUrl rejects values that are not review URLs', () => {
expect(parseReviewUrl(value)).toBe(null);
}
});

test('parseRemoteUrl drops a custom port from `ssh://` remotes', () => {
expect(parseRemoteUrl('ssh://git@gitlab.example.com:2222/group/project.git')).toEqual({
host: 'gitlab.example.com',
projectPath: 'group/project',
provider: 'gitlab',
});
});

test('parseRemoteUrl keeps an explicit port on `https://` remotes', () => {
expect(parseRemoteUrl('https://gitlab.example.com:8443/group/subgroup/project.git')).toEqual({
host: 'gitlab.example.com:8443',
projectPath: 'group/subgroup/project',
provider: 'gitlab',
});
});

test('parseRemoteUrl reads scp-style and GitHub remotes', () => {
expect(parseRemoteUrl('git@gitlab.example.com:group/project.git')).toEqual({
host: 'gitlab.example.com',
projectPath: 'group/project',
provider: 'gitlab',
});
expect(parseRemoteUrl('https://github.com/nkzw-tech/codiff.git')).toEqual({
host: 'github.com',
projectPath: 'nkzw-tech/codiff',
provider: 'github',
});
});
6 changes: 5 additions & 1 deletion electron/review-source.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,10 @@ const parseRemoteUrl = (value) => {
const projectPath = url.pathname.replaceAll(/^\/+|\.git$/gi, '');
return projectPath
? {
host: url.host.toLowerCase(),
// A custom SSH port (`ssh://git@host:2222/...`) is transport detail, not part
// of the instance identifier, and glab's `--hostname` rejects `host:port` —
// strip it. An explicit port on `https://` remotes stays: it identifies the instance.
host: (url.protocol === 'ssh:' ? url.hostname : url.host).toLowerCase(),
projectPath,
provider: /** @type {ReviewProvider} */ (
url.hostname.toLowerCase() === 'github.com' ? 'github' : 'gitlab'
Expand Down Expand Up @@ -175,6 +178,7 @@ const resolveReviewUrl = (repositoryPath, number, provider) => {
};

module.exports = {
parseRemoteUrl,
parseReviewUrl,
readReviewRemotes,
resolveReviewUrl,
Expand Down