Skip to content

feat(check): file panels (client.addFilePanel, Paseo 0.13.0) - #3

Closed
nkwib wants to merge 4 commits into
mainfrom
feat/file-panels
Closed

nkwib wants to merge 4 commits into
mainfrom
feat/file-panels

Conversation

@nkwib

@nkwib nkwib commented Oct 21, 2026

Copy link
Copy Markdown
Owner

What and why

client.addFilePanel (getpaseo/paseo#7411) ships in Paseo 0.13.0. ppd check failed every plugin that called it as not part of the client context.

  • The client rules mirror addFilePanel in evaluate.ts at e464fd3, with parsePluginIcon and the files selector. The notice header and THIRD_PARTY_NOTICES name that revision.
  • Below 0.13.0 the method is undefined, so an unguarded call drops the whole client. When requirements.paseo admits such a release, the client is evaluated again without the method, and a throw is a client-eval warning (a note in ppd install and ppd dev). CLIENT_METHOD_SINCE takes later methods in one line.
WARN  client-eval      on Paseo before 0.13.0, which requirements.paseo ">=0.11.2" admits, client.addFilePanel is undefined and the contribution throws, so those apps show none of this client. Declare ">=0.13.0" or guard with typeof client.addFilePanel === "function"

Not mirrored: an unknown Lucide name keeps the devkit's message, and { svg } icon markup is not validated.

Verified with

  • npm run typecheck && npm test
  • node dist/cli.js check examples/hello-plugin after npm run build
  • Touches the daemon, install, web or android paths: ran it against a dev daemon (never port 6767 or ~/.paseo)

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Deploying paseo-plugin-devkit with  Cloudflare Pages  Cloudflare Pages

Latest commit: b34b1b8
Status: ✅  Deploy successful!
Preview URL: https://01886ecf.paseo-plugin-devkit.pages.dev
Branch Preview URL: https://feat-file-panels.paseo-plugin-devkit.pages.dev

View logs

@nkwib nkwib mentioned this pull request Oct 21, 2026
nkwib added 4 commits October 21, 2026 11:09
client.addFilePanel ships in Paseo 0.13.0. ppd check failed every plugin
that calls it as "not part of the app's plugin client context". The rules
now mirror evaluate.ts at e464fd3: id, duplicate, title, icon, the files
selector and a function Component (a memo object fails, as in the app).
File panel icons follow parsePluginIcon: a Lucide name, { svg } or a
component.
…d method

Below Paseo 0.13.0 client.addFilePanel is undefined, so an unguarded call
throws and the app drops the whole client. The recording client answered
every add* call, so ppd check could not see it. When the range admits a
release older than a method the client calls (CLIENT_METHOD_SINCE), the
client is evaluated again with that method undefined. A throw there is a
client-eval warning, and a note in ppd install and ppd dev, naming the
range and the fix.
README, the docs site check page and the skill's host contract list the
file panel rules and the requirements.paseo warning; the MIME row now
points at file panels on 0.13.0.
@nkwib

nkwib commented Oct 30, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #7, which includes these file panel rules and the requirements.paseo warning on top of version-aware checks.

@nkwib nkwib closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant