Repository navigation
Conversation
Deploying paseo-plugin-devkit with
|
| Latest commit: |
b34b1b8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://01886ecf.paseo-plugin-devkit.pages.dev |
| Branch Preview URL: | https://feat-file-panels.paseo-plugin-devkit.pages.dev |
Merged
client.addFilePanel ships in Paseo 0.13.0. ppd check failed every plugin
that calls it as "not part of the app's plugin client context". The rules
now mirror evaluate.ts at e464fd3: id, duplicate, title, icon, the files
selector and a function Component (a memo object fails, as in the app).
File panel icons follow parsePluginIcon: a Lucide name, { svg } or a
component.
…d method Below Paseo 0.13.0 client.addFilePanel is undefined, so an unguarded call throws and the app drops the whole client. The recording client answered every add* call, so ppd check could not see it. When the range admits a release older than a method the client calls (CLIENT_METHOD_SINCE), the client is evaluated again with that method undefined. A throw there is a client-eval warning, and a note in ppd install and ppd dev, naming the range and the fix.
README, the docs site check page and the skill's host contract list the file panel rules and the requirements.paseo warning; the MIME row now points at file panels on 0.13.0.
nkwib
force-pushed
the
feat/file-panels
branch
from
October 21, 2026 09:11
de866aa to
b34b1b8
Compare
Owner
Author
|
Superseded by #7, which includes these file panel rules and the requirements.paseo warning on top of version-aware checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
client.addFilePanel(getpaseo/paseo#7411) ships in Paseo 0.13.0.ppd checkfailed every plugin that called it as not part of the client context.addFilePanelinevaluate.tsat e464fd3, withparsePluginIconand thefilesselector. The notice header andTHIRD_PARTY_NOTICESname that revision.requirements.paseoadmits such a release, the client is evaluated again without the method, and a throw is aclient-evalwarning (a note inppd installandppd dev).CLIENT_METHOD_SINCEtakes later methods in one line.Not mirrored: an unknown Lucide name keeps the devkit's message, and
{ svg }icon markup is not validated.Verified with
npm run typecheck && npm testnode dist/cli.js check examples/hello-pluginafternpm run build~/.paseo)