Conversation
Shipping verdict PASS+NOTES (orchestrator). - Scope limited to Polymarket overlay + Phase 0/1 docs. - Converter smoke verified earlier. - Full Rust/maturin suite not run on box (rustc 1.85 < 1.91.1).
Replace float(None) with an explicit ValueError so null sizes in a book row raise a clear error, matching the trade price null check. Co-authored-by: tommy-ca <tommy-ca@users.noreply.github.com>
…er (#3) Deduplicate outcome token lists used by trade mirroring and resolve settlement so aliases stay identical. Co-authored-by: tommy-ca <tommy-ca@users.noreply.github.com>
Document resolve-book injection in the converter and snap-to-0/1 safety net in PolyAssetRecord / fix_record_prices. Docs only; no behavior change.
Document BinaryFee rate meaning (negative = rebate) in the Polymarket examples README and clarify Stats.earn as last equity after fee with settlement pointers. Co-authored-by: tommy-ca <tommy-ca@users.noreply.github.com>
Document fixed ROI/tick/lot/queue settings and how to override queue or tick via plain BacktestAsset with the same ROI bounds. Co-authored-by: tommy-ca <tommy-ca@users.noreply.github.com>
Script reports commits on upstream/master not in HEAD. UPSTREAM.md documents rebase/merge policy and pin updates after sync. Co-authored-by: tommy-ca <tommy-ca@users.noreply.github.com>
PR-E race left two identical sections in PRODUCT.md; keep one. Co-authored-by: tommy-ca <tommy-ca@users.noreply.github.com>
Install project-local intent-driven schema + companion skills, seed Static honesty specs (product-boundary, upstream-hygiene, polymarket-overlay, verify-levers), and land propose artefacts for hftbacktest-openspec-bootstrap. No live connectors; overlay stays additive; no invent CI green.
Author
|
Opened by mistake against upstream fork default; Wave-4 propose belongs on tommy-ca/hftbacktest only. Closing. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 18 minor |
| Security | 2 medium 2 minor 4 high |
| CodeStyle | 74 minor |
🟢 Metrics 181 complexity · 11 duplication
Metric Results Complexity 181 Duplication 11
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hftbacktest-overlay-solid-dryhftbacktest-verify-ci-baselinehftbacktest-docs-boundary-honesty.openspec.yaml, proposal/design/tasks/adr, and delta specs;openspec validate --type change --strictPASS for all three.Test plan
/home/box/bin/openspec validate --type change --strict hftbacktest-overlay-solid-dry/home/box/bin/openspec validate --type change --strict hftbacktest-verify-ci-baseline/home/box/bin/openspec validate --type change --strict hftbacktest-docs-boundary-honesty