[Animation] Snappy, Skippable & Informative Animations#609
Merged
Conversation
## Summary Makes combat animations snappier and adds player controls to skip animations or slow them down for threat analysis. ## Changes ### Config speedups - config/feedback_config.json: damage_numbers duration 1.0s → 0.4s - config/hud_config.json: turn_banner durations snappier - fade_duration 0.3 → 0.2, slide_duration 0.5 → 0.3 - display_duration 1.2 → 0.6 - Added lethal screen_shake intensity (6.0) and duration (0.25) ### Skip animation (Spacebar) - _skip_animations() in CombatRoom: kills camera shake, hides turn banner, removes floating text labels, resets status bar opacity - Bound to Spacebar in _unhandled_input() during any combat phase ### Slow-motion preview (Shift during enemy turn) - _process() checks if Shift is held during ENEMY_TURN - Sets Engine.time_scale = 0.5; resets to 1.0 on release or phase change - _exit_tree() resets time_scale to prevent stuck slow-motion ### Lethal screenshake - _on_entity_state_changed(): stronger camera shake (1.5x) on enemy death - trigger_camera_shake(): respects accessibility screen_shake setting from SettingsManager (0.0 = disabled) ### Floating text snappiness - CombatHUD.show_floating_text(): reads duration from feedback_config instead of hardcoded 1.0s ### SettingsManager - Added get_value(category, key, fallback) convenience getter ## Testing - 403 tests | 0 errors | 0 failures | 75/75 suites - Headless editor scan: clean Closes #602
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes combat animations snappier and adds player controls to skip animations or slow them down for threat analysis.
Problem
Community research shows players want snappy, skippable, informative animations. Current placeholder/minimal animations were too slow (turn banner 2.3s total) or lacked feedback (no unit flash on damage, no skip option).
Changes
Snappier default durations
Skip animation (Spacebar)
Slow-motion preview (Shift during enemy turn)
_exit_tree()guard resets time scale to prevent stuck slow-motion on scene changeLethal screenshake
screen_shakesetting from SettingsManager (0.0 = completely disabled)Config-driven floating text
CombatHUD.show_floating_text()now reads duration fromfeedback_config.jsoninstead of hardcoded 1.0sSettingsManager
get_value(category, key, fallback)convenience getter for cross-system accessEdge Cases Handled
Testing
Related Issues
Closes #602