Add Nix logger activity bindings - #71
Open
domenkozar wants to merge 1 commit into
Open
domenkozar wants to merge 1 commit into
domenkozar wants to merge 1 commit into
Conversation
domenkozar
marked this pull request as ready for review
August 10, 2026 22:28
Contributor
|
Seems useful, but bypassing the upstream C API will be quite the can of worms. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nix-bindings-loggercrateWhy
Nix's C API does not expose logger emission. Code loaded into a Nix process—such as a store plugin—needs to create
nix::Activityinstances so build output appears innix build -Lwithout carrying an application-specific C++ shim.Impact
Downstream plugins can reuse a small, process-safe Rust API for Nix logging while keeping application-specific plugin bindings separate.
Validation
cargo fmt --all -- --checkcargo test -p nix-bindings-loggerwith Nix 2.34nix-instantiate --parsecc @roberth