Repository navigation
Preserve failed bulk reads with bounded per-chat retries - #167
Conversation
Retain the mark-all click boundary across failure and interruption, then recover through timestamp-bounded conversation reads. Keep service identifiers scoped locally and preserve newer arrivals and explicit gestures. Persist each attempt before invoking Messages and reject a locked Mac before acquiring its UI lock. Cover durable read-sync invariants with regression tests. Fixes nixfred#166.
|
Hi Curtis, thank you, and welcome. This is a strong first PR: a real bug found on a real locked gateway, filed as its own issue (#166), four regression cases that fail on unmodified main before the fix, and a fix that reuses the existing timestamp guard instead of ever repeating the unbounded Checked and fine: merges cleanly on main Blocker: under the default
Under Should-fix (the first three the reviewer ran, the rest read; I did not re-run these)
Thank you again. Push when ready and I will re-run the Generated by Claude Code |
…phic, X-POSTS row) WHAT: docs/x-post-2026-11-14.txt (5,465 characters, 14 handles each tagged once, no em dashes), the 1600x900 graphic docs/img/x-post-2026-11-14.png with its HTML source, and the X-POSTS.md row. WHY: Fred asked for a detailed thank-you post covering every contributor since the last posted update (Post 4, 26 Sep). Posts 5, 6, 7 and W45 were never posted, so this one replaces them: 40 merged PRs, 38 from 18 outside people, 2 ours, one cherry-pick (David Benedic), one reporter (edmooredop), and two PRs in review (Jason Alexander #165, Curtis Chambers #167). HANDLES: from CONTRIBUTORS-X.md (all 13 match); @jasona verified on his GitHub profile and x user; no X for Marcus (credit by GitHub handle, haplab.com), Erik, Gerald, Colton, Dima, David, edmooredop, Curtis: named without @. PLACED on vic's clipboard (image first so it sits in history, text last) and the PNG at ~/Pictures/blip-thank-you-2026-11-14.png on vic. LR-T: blip, x-post, contributors, thank-you, graphic LR-D: blip, docs, comms LR-K: blip-post-8-all-contributors-since-26-sep Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BXN1v67b9f9VHGe3FhaQuD
WHAT: CHANGE.log entries for #167 (Curtis Chambers, no X known) and #165 (Jason Alexander, @jasona verified via x user), roster rows for both, weekly note for Mon 16 Nov. WHY: standing rule, every merged PR gets its change line and roster row the day it merges, with the verified X handle or the honest 'none known'. LR-T: blip, docs, change-log, roster, pr-165, pr-167 LR-D: blip LR-K: change-log-16-nov Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BXN1v68N3DWV2UhtuJggZz
|
Merged in One thing I changed in the merge, so you are not surprised when you pull: the per-chat expansion now runs only under I left the review's six should-fix items for follow-up, none blocking: the leftover marker for business threads keeps the old error on screen, a message stamped ahead of the Linux clock can come back unread after a failed mark-all, and One small question: do you have an X account you would like credited? Your GitHub profile lists none, so for now I credit you as github.com/curtisc. Generated by Claude Code |
… 14 Nov correction WHAT: WEEKLY-NOTES.md gets its own 2026-W47 section (Mon 16 to Sun 22 Nov). The "Mon 16 Nov: #167 and #165 merged" block moves into it from W46, where it was mis-filed (16 Nov 2026 is a Monday, ISO week 47). W47 also records the audit of all 128 merged PRs: 21 of them (#37 #38 #40 #41 #42 #46 #50 #51 #52 #53 #55 #56 #57 #58 #59 #60 #63 #64 #65 #66 #67, merged 6 to 10 Sep) had no comment and no review from nixfred, so each now carries a specific thank-you on the PR itself (Erik Fillipsveen @Fileri 13, Jon Kinney @jondkinney 7, Danny Cecil @jefehoser 1). W46 gains Jason Alexander's 14 Nov correction to his own #165 evidence, quoted verbatim, which is why #165 stays "not yet proven on a real RCS contact". WHY: standing rule (Fred, 2026-10-31): audit every merged PR at the start of a run and thank any author who got no visible comment; notes are written the day the work lands. VERIFIED: bun test on main, 927 pass, 0 fail, before the comments went out; all 21 comments posted without a failure. OPEN: 2.6.2 (26 Sep) is still the latest release and manifest.json says 2.6.2 while CHANGELOG.md Unreleased holds every PR since; a release is Fred's call. Erik, the largest contributor (22 PRs), is not named in Post 4 or the 2.6.2 release notes. LR-T: blip, weekly-notes, contributors, thank-you, audit, w47 LR-D: blip, docs, github, community LR-K: blip-catchup-thanks-21-prs-2026-11-17, blip-w47-section, jasona-165-correction Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BXN1v3tUKC1p1NZKBgXXvk
What
Keep Mark All as Read effective locally when the Mac cannot complete the read action. A failed or interrupted bulk attempt now retains its original click timestamp and becomes per-conversation
--throughretries after a complete read-state snapshot is available. Newer incoming activity stays unread, and later explicit read/unread gestures take precedence.Persist an attempt before invoking the bridge so a collector interrupted during
--allnever repeats that unbounded action. Refuse a known locked screen before acquiring the Messages UI lock or starting AppleScript.Closes #166.
Why
Under
push_read=thread, the next confirmed Mac snapshot supersedes historical local read marks. The old failure path deleted the bulk intent, so an unsuccessful Mark All as Read temporarily cleared the badge and then restored the same old unread conversations. This was observed as a recurring count of 15 on a locked gateway.#133 already made individual read intents durable; it deliberately excluded
--allbecause a later unbounded retry could consume new arrivals. This extends durability using the existing timestamp guard instead of repeating--all. It also handles service identifiers that cannot be opened individually: a scoped local marker survives without blocking other actions.How it was verified
bun test: 885 passed, 0 failed, including the new bulk-read regressions.69ca3ab(lost bulk intent, unavailable snapshot, missing pre-action persistence, and interrupted bulk attempt repeating--all). They pass with this change.CLAUDE.md, and documented recovery behavior inREADME.md.Limits
The Mac must still be unlocked for Messages UI actions to succeed. This does not change that platform limitation or make the UI action asynchronous (the broader blocking-call work remains in #125). A failed bulk intent waits for a complete snapshot; it never retries an unbounded
--all. Service/business identifiers that cannot be opened individually retain their local marker and need a later successful mark-all in Messages to synchronize. No message bodies are persisted; the additional state contains only bounded conversation identifiers.